-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document docker dangling container reaper #6762
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -166,7 +166,7 @@ The `docker` driver supports the following configuration in the job spec. Only | |||||
} | ||||||
``` | ||||||
|
||||||
* `logging` - (Optional) A key-value map of Docker logging options. | ||||||
* `logging` - (Optional) A key-value map of Docker logging options. | ||||||
Defaults to `json-file` with log rotation (`max-file=2` and `max-size=2m`). | ||||||
|
||||||
```hcl | ||||||
|
@@ -648,6 +648,13 @@ plugin "docker" { | |||||
image = true | ||||||
image_delay = "3m" | ||||||
container = true | ||||||
|
||||||
dangling_containers { | ||||||
enabled = true | ||||||
dry_run = false | ||||||
period = "5m" | ||||||
creation_grace = "5m" | ||||||
} | ||||||
} | ||||||
|
||||||
volumes { | ||||||
|
@@ -690,7 +697,7 @@ plugin "docker" { | |||||
* `config`<a id="plugin_auth_file"></a> - Allows an operator to specify a | ||||||
JSON file which is in the dockercfg format containing authentication | ||||||
information for a private registry, from either (in order) `auths`, | ||||||
`credHelpers` or `credsStore`. | ||||||
`credHelpers` or `credsStore`. | ||||||
* `helper`<a id="plugin_auth_helper"></a> - Allows an operator to specify a | ||||||
[credsStore](https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol) | ||||||
-like script on $PATH to lookup authentication information from external | ||||||
|
@@ -719,6 +726,18 @@ plugin "docker" { | |||||
* `container` - Defaults to `true`. This option can be used to disable Nomad | ||||||
from removing a container when the task exits. Under a name conflict, | ||||||
Nomad may still remove the dead container. | ||||||
* `dangling_containers` stanza for controlling dangling container detection | ||||||
and cleanup: | ||||||
* `enabled` - Defaults to `true`. Enables dangling container handling. | ||||||
* `dry_run` - Defaults to `false`. Only log dangling containers without | ||||||
cleaning them up. | ||||||
* `period` - Defaults to `"5m"`. A time duration that controls interval | ||||||
between Nomad scans for dangling containers. | ||||||
* `creation_grace` - Defaults to `"5m"`. Grace period after a container is | ||||||
created during which the GC ignores it. Only used to prevent the GC from | ||||||
removing newly created containers before they are registered with the | ||||||
GC. Should not need adjusting higher but may be adjusted lower to GC | ||||||
more aggressively. | ||||||
|
||||||
* `volumes` stanza: | ||||||
* `enabled` - Defaults to `true`. Allows tasks to bind host paths | ||||||
|
@@ -894,7 +913,31 @@ need a higher degree of isolation between processes for security or other | |||||
reasons, it is recommended to use full virtualization like | ||||||
[QEMU](/docs/drivers/qemu.html). | ||||||
|
||||||
## Docker for Windows Caveats | ||||||
## Caveats | ||||||
|
||||||
### Dangling Containers | ||||||
|
||||||
Nomad 0.10.2 introduces a detector and a reaper for dangling Docker containers, | ||||||
containers that Nomad starts yet does not manage or track. Though rare, they | ||||||
lead to unexpectedly running services, potentially with stale versions. | ||||||
|
||||||
When Docker daemon becomes unavailable as Nomad starts a task, it is possible | ||||||
for Docker to successfully start the container and fails the API call with 500 | ||||||
error code. In such cases, Nomad retries and eventually aims to kill such | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
containers. However, if the Docker Engine remains unhealthy, subsequent retries | ||||||
and stop attempts may still fail, and the started container becomes a dangling | ||||||
container that Nomad no longer manages. | ||||||
|
||||||
The newly added reaper periodically scans for such containers. It only targets | ||||||
containers with a `com.hashicorp.nomad.allocation_id` label, or match Nomad's | ||||||
conventions for naming and bind-mounts (i.e. `/alloc`, `/secrets`, `local`). | ||||||
Containers that don't match Nomad container patterns are left untouched. | ||||||
|
||||||
Operators can run the reaper in a dry run mode, where it only logs dangling | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
container ids without killing them, or simply disable it through | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
the `gc.dangling_containers` config stanza. | ||||||
|
||||||
### Docker for Windows | ||||||
|
||||||
Docker for Windows only supports running Windows containers. Because Docker for | ||||||
Windows is relatively new and rapidly evolving you may want to consult the | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -15,6 +15,16 @@ details provided for their upgrades as a result of new features or changed | |||||
behavior. This page is used to document those details separately from the | ||||||
standard upgrade flow. | ||||||
|
||||||
## Nomad 0.10.2 | ||||||
|
||||||
Nomad 0.10.2 addresses an issue occurring in heavily loaded clients, where | ||||||
containers are started without being properly managed by Nomad. Nomad 0.10.2 | ||||||
introduced a reaper that detects and kills such containers. | ||||||
|
||||||
Operators may opt to run reaper in a dry mode or disabling it through a client config. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
For more information, see [Docker Dangling containers][dangling-containers]. | ||||||
|
||||||
## Nomad 0.10.0 | ||||||
|
||||||
### Deployments | ||||||
|
@@ -364,6 +374,7 @@ deleted and then Nomad 0.3.0 can be launched. | |||||
|
||||||
[drain-api]: /api/nodes.html#drain-node | ||||||
[drain-cli]: /docs/commands/node/drain.html | ||||||
[dangling-containers]: /docs/drivers/docker.html#dangling-containers | ||||||
[hcl2]: https://github.com/hashicorp/hcl2 | ||||||
[lxc]: /docs/drivers/external/lxc.html | ||||||
[migrate]: /docs/job-specification/migrate.html | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.