[ui] Line charts: explicitly update X-axis whenever xScale changes (#…

…14814) * Explicitly update X-axis whenever xScale changes * Changelog
hashicorp · Oct 6, 2022 · 8a3c975 · 8a3c975
1 parent a138821
commit 8a3c975
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/.changelog/14814.txt b/.changelog/14814.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+ui: Fixed line charts to update x-axis (time) where relevant
+```
diff --git a/ui/app/components/line-chart.js b/ui/app/components/line-chart.js
@@ -350,6 +350,13 @@ export default class LineChart extends Component {
     });
   }
 
+  @action
+  recomputeXAxis(el) {
+    if (!this.isDestroyed && !this.isDestroying) {
+      d3.select(el.querySelector('.x-axis')).call(this.xAxis);
+    }
+  }
+
   mountD3Elements() {
     if (!this.isDestroyed && !this.isDestroying) {
       d3.select(this.element.querySelector('.x-axis')).call(this.xAxis);

diff --git a/ui/app/templates/components/line-chart.hbs b/ui/app/templates/components/line-chart.hbs
@@ -3,6 +3,7 @@
   ...attributes
   {{did-insert this.onInsert}}
   {{did-update this.renderChart}}
+  {{did-update this.recomputeXAxis this.xScale}}
   {{window-resize this.updateDimensions}}>
   <svg data-test-line-chart aria-labelledby="{{this.titleId}}" aria-describedby="{{this.descriptionId}}">
     <title id="{{this.titleId}}">{{this.title}}</title>