[ui] Line charts: explicitly update X-axis whenever xScale changes #14814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14808
Previously (for quite awhile perhaps?) the chart line would move above the time x-axis, but the axis itself would never update. While it is cool to rip a hole in space-time via client-side javascript, it's probably better that we scroll the ticks as new x-scale extents update.
Side-note: I am skeptical if the
{{did-update this.renderChart}}
does anything at all.renderChart()
is also called, once removed, from theonInsert
modifier-fired action. But I don't think the template modifier triggers at all.