Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Recompute Y Axis on data change #15381

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

philrenaud
Copy link
Contributor

Resolves #15098


Uses a did-update triggered on yScale() to manually re-call the yAxis scale formatter. Similar change to what we did in #14814.

image

@github-actions
Copy link

Ember Asset Size action

As of 8fc9a69

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +296 B +24 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main 8fc9a69 change
passes 1425 1425 0
failures 0 0 0
flaky 0 0 0
duration 10m 00s 664ms 10m 35s 707ms +35s 043ms

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

UI: CPU Scale is wrong.
2 participants