getter: allow the gcs download scheme (#6692)

hashicorp · Nov 19, 2019 · c47d52e · c47d52e
1 parent 8fa68ca
commit c47d52e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/client/allocrunner/taskrunner/getter/getter.go b/client/allocrunner/taskrunner/getter/getter.go
@@ -18,7 +18,7 @@ var (
 	lock    sync.Mutex
 
 	// supported is the set of download schemes supported by Nomad
-	supported = []string{"http", "https", "s3", "hg", "git"}
+	supported = []string{"http", "https", "s3", "hg", "git", "gcs"}
 )
 
 const (

diff --git a/client/allocrunner/taskrunner/getter/getter_test.go b/client/allocrunner/taskrunner/getter/getter_test.go
@@ -342,6 +342,13 @@ func TestGetGetterUrl_Queries(t *testing.T) {
 			},
 			output: "bucket.s3-eu-west-1.amazonaws.com/foo/bar?aws_access_key_id=abcd1234",
 		},
+		{
+			name: "gcs",
+			artifact: &structs.TaskArtifact{
+				GetterSource: "gcs::https://www.googleapis.com/storage/v1/b/d/f",
+			},
+			output: "gcs::https://www.googleapis.com/storage/v1/b/d/f",
+		},
 		{
 			name: "local file",
 			artifact: &structs.TaskArtifact{