Getter: allow the GCS download scheme #6692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a manual test langmartin/nomad-dev#1, go-getter covers this test internally well, I don't think that adding it to nomad's e2e adds much value. |
langmartin
force-pushed
the
f-gcs-downloads
branch
from
0dd90f1
to
fb7aec1
Compare
langmartin
force-pushed
the
f-gcs-downloads
branch
from
fb7aec1
to
ee24b3a
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already using a go-getter version that supports GCS downloads, but need to enable the download scheme. This still does not support symlinks in tarballs as referenced in #5445, pending the go-getter merge in hashicorp/go-getter#192