Correct the status description and modify time of canceled evals. (#1…

…7071)

Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.

.changelog/17071.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+bug: Corrected status description and modification time for canceled evaluations
+```

nomad/state/state_store.go

@@ -3120,11 +3120,12 @@ func (s *StateStore) nestedUpsertEval(txn *txn, index uint64, eval *structs.Eval
 		}
 
 		// Go through and update the evals
-		for _, eval := range blocked {
-			newEval := eval.Copy()
+		for _, blockedEval := range blocked {
+			newEval := blockedEval.Copy()
 			newEval.Status = structs.EvalStatusCancelled
-			newEval.StatusDescription = fmt.Sprintf("evaluation %q successful", newEval.ID)
+			newEval.StatusDescription = fmt.Sprintf("evaluation %q successful", eval.ID)
 			newEval.ModifyIndex = index
+			newEval.ModifyTime = eval.ModifyTime
 
 			if err := txn.Insert("evals", newEval); err != nil {
 				return fmt.Errorf("eval insert failed: %v", err)

nomad/state/state_store_test.go

@@ -4108,6 +4108,14 @@ func TestStateStore_UpsertEvals_CancelBlocked(t *testing.T) {
 		t.Fatalf("bad: %#v %#v", out1, out2)
 	}
 
+	if !strings.Contains(out1.StatusDescription, eval.ID) || !strings.Contains(out2.StatusDescription, eval.ID) {
+		t.Fatalf("bad status description %#v %#v", out1, out2)
+	}
+
+	if out1.ModifyTime != eval.ModifyTime || out2.ModifyTime != eval.ModifyTime {
+		t.Fatalf("bad modify time %#v %#v", out1, out2)
+	}
+
 	if watchFired(ws) {
 		t.Fatalf("bad")
 	}