Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceled evaluation provide circular or wrong debug information. #17070

Closed
stswidwinski opened this issue May 3, 2023 · 2 comments
Closed

Canceled evaluation provide circular or wrong debug information. #17070

stswidwinski opened this issue May 3, 2023 · 2 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/core type/bug

Comments

@stswidwinski
Copy link
Contributor

Nomad version

Built off tip

Operating system and Environment details

Unix

Issue

When an evaluation is canceled, it produces confusing or wrong debug information. In particular:

$ nomad eval status  -namespace '*' -json 81235e65
{
    [...]
    "CreateIndex": 6445487,
    "CreateTime": 1682965847060638834,
    [...]
    "ModifyIndex": 6445493,
    "ModifyTime": 1682965847060638834,
    [...]
    "Status": "canceled",
    "StatusDescription": "evaluation \"81235e65-7e71-9595-0a34-00674bff2b75\" successful",
    [...]
}

There are a few interesting points:

  1. CreateIndex and ModifyIndex are different but CreateTime and ModifyTime are the same. In practice the times should be 30 seconds apart.
  2. StatusDescription reports the successful evaluation as the same evaluation which is canceled. This is not the intended information.

I will submit a proposed patch to fix these fields below.

@jrasell
Copy link
Member

jrasell commented May 4, 2023

Hi @stswidwinski thanks for raising this issue and the corresponding PR. We will take a look into this shortly.

@jrasell jrasell added theme/core stage/accepted Confirmed, and intend to work on. No timeline committment though. labels May 4, 2023
@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation May 4, 2023
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage May 4, 2023
tgross pushed a commit that referenced this issue May 8, 2023
…7071)

Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.
tgross pushed a commit that referenced this issue May 8, 2023
…7071)

Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.
tgross pushed a commit that referenced this issue May 8, 2023
…7071)

Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.
tgross pushed a commit that referenced this issue May 8, 2023
…7071)

Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.
@tgross
Copy link
Member

tgross commented May 17, 2023

Fixed in #17071 which will ship in the next release of Nomad 1.5.x, with backports to 1.4.x and 1.3.x.

@tgross tgross closed this as completed May 17, 2023
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/core type/bug
Projects
Development

No branches or pull requests

3 participants