Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: filename arg for volume init and quote init #10397

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Apr 19, 2021

Allow optional filename as an argument for volume init and quote init commands, to match job init behavior.

Updated tests to use testify as well.

Fixes #10198

@notnoop notnoop self-assigned this Apr 19, 2021
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross added this to the 1.1.0 milestone Apr 19, 2021
@notnoop notnoop merged commit 2051f67 into main Apr 19, 2021
@notnoop notnoop deleted the f-cli-file-arg branch April 19, 2021 15:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume init and quota init should take filename param
2 participants