Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix a bug where redirects after planning/editing a job didn't include namespace #13588

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

philrenaud
Copy link
Contributor

Previously, we treated namespaces like query parameters; however, this caused the onSubmit redirects to 404 when planning a job.

Side-effect: also introduces router service transition instead of depending on the deprecated transitionToRoute method.

Resolves #13039

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Ember Asset Size action

As of 1816ce2

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +907 B +337 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Ember Test Audit comparison

main 1816ce2 change
passes 1287 1287 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI edit job results in redirect to wrong url to view job
2 participants