Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Fix a bug where redirects after planning/editing a job didn't include namespace into release/1.3.x #13599

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13588 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Previously, we treated namespaces like query parameters; however, this caused the onSubmit redirects to 404 when planning a job.

Side-effect: also introduces router service transition instead of depending on the deprecated transitionToRoute method.

Resolves #13039

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/13039-plan-redirect-namespace-bug/fully-fitting-buffalo branch 2 times, most recently from fc2faa3 to 578f70a Compare July 5, 2022 19:59
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 78e69fe into release/1.3.x Jul 5, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/13039-plan-redirect-namespace-bug/fully-fitting-buffalo branch July 5, 2022 19:59
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Ember Test Audit comparison

release/1.3.x 578f70a change
passes 1287 1285 -2
failures 2 2 0
flaky 0 2 +2
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 578f70a:

  • Acceptance | optimize: lets recommendations be toggled, reports the choices to the recommendations API, and displays task group recommendations serially
  • Acceptance | task group detail: facet Status | the Status facet filters the allocations list by Status

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants