ui: use task state to determine if task is active #14224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses the task's finishedAt field to determine if a task is active of not, but this check is not accurate. A task in the "pending" state will not have finishedAt value but it's also not active. This discrepancy results in some components, like the inline stats chart of the task row component, to be displayed even whey they shouldn't.
lgfa29
added
backport/1.1.x
Ember Asset Size actionAs of 434ee99 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
approved these changes
Aug 22, 2022
Comment on lines
+60
to
+63
| @computed('state') | ||
| get isActive() { | ||
| return this.state === 'running'; | ||
| } |
There was a problem hiding this comment.
praise: Very smart to map running to active. This will age well!
Comment on lines
+190
to
+193
| const task = server.db.taskStates | ||
| .where({ allocationId: allocation.id }) | ||
| .sortBy('name')[i]; | ||
| const events = server.db.taskEvents.where({ taskStateId: task.id }); |
There was a problem hiding this comment.
praise: excellent use of those Mirage APIs!
|
Seems like I broke something. I will fix the tests tomorrow before merge 👍 |
This was referenced Aug 23, 2022
lgfa29
added a commit
that referenced
this pull request
Aug 23, 2022
The current implementation uses the task's finishedAt field to determine if a task is active of not, but this check is not accurate. A task in the "pending" state will not have finishedAt value but it's also not active. This discrepancy results in some components, like the inline stats chart of the task row component, to be displayed even whey they shouldn't.
lgfa29
added a commit
that referenced
this pull request
Aug 23, 2022
The current implementation uses the task's finishedAt field to determine if a task is active of not, but this check is not accurate. A task in the "pending" state will not have finishedAt value but it's also not active. This discrepancy results in some components, like the inline stats chart of the task row component, to be displayed even whey they shouldn't.
lgfa29
added a commit
that referenced
this pull request
Aug 23, 2022
The current implementation uses the task's finishedAt field to determine if a task is active of not, but this check is not accurate. A task in the "pending" state will not have finishedAt value but it's also not active. This discrepancy results in some components, like the inline stats chart of the task row component, to be displayed even whey they shouldn't. Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Aug 23, 2022
The current implementation uses the task's finishedAt field to determine if a task is active of not, but this check is not accurate. A task in the "pending" state will not have finishedAt value but it's also not active. This discrepancy results in some components, like the inline stats chart of the task row component, to be displayed even whey they shouldn't. Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses the task's finishedAt field to determine
if a task is active of not, but this check is not accurate. A task in
the "pending" state will not have finishedAt value but it's also not
active.
This discrepancy results in some components, like the inline stats chart
of the task row component, to be displayed even whey they shouldn't.