Fix error handling in Client consulDiscoveryImpl

[nvx]

Trivial one-liner fix, added a missing continue on non-nil error to avoid accidentally using a bad peer.

I ran into this while updating a single server test cluster to raft version 3 (https://www.nomadproject.io/docs/upgrade#upgrading-a-single-server-cluster-to-raft-version-3) by creating a raft.peers file manually and forgetting to include the port in the address field. This resulted in clients discovering via Consul to appear to successfully detect a server, but then later failing with errors like this:

client.rpc: error performing RPC to server: error="rpc error: failed to get conn: dial tcp: address <nil>: missing port in address" rpc=Node.GetClientAllocs server=<nil>

This fix will allow allow the client to check for other servers with functional Status.Peers responses, or in the absence of a functional server at least return a relevant error in the right place.

[lgfa29]

Nice catch, thank you @nvx 🙂

I added a changelog entry for this fix.

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.