migrate autopilot implementation to raft-autopilot #14441
Conversation
Nomad's original autopilot was importing from a private package in Consul. It has been moved out to a shared library. Switch Nomad to use this library so that we can eliminate the import of Consul, which is necessary to build Nomad ENT with the current version of the Consul SDK. This also will let us pick up autopilot improvements shared with Consul more easily.
tgross
force-pushed
the
autopilot-upgrade
branch
from
7d59d25
to
0163f19
Compare
| @@ -40,7 +40,6 @@ require ( | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/gosuri/uilive v0.0.4 | |||
| github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 | |||
| github.com/hashicorp/consul v1.7.8 | |||
| // immediately so we'll spawn a goroutine for it.) | ||
| func (d *AutopilotDelegate) RemoveFailedServer(failedSrv *autopilot.Server) { | ||
| go func() { | ||
| err := d.server.RemoveFailedNode(failedSrv.Name) |
There was a problem hiding this comment.
Is Name here the agent's name? Would it be possible to remove by ID instead in case the cluster has servers with duplicate names (which I think is allow, though not a good idea 😅)?
There was a problem hiding this comment.
It's the serf.Member.Name, which I think is the same thing. I originally had this by ID (which is what Consul does) but our existing RemoveFailedNode code only accepts the name and not the ID. I didn't want to change the behavior here.
| @@ -40,7 +40,6 @@ require ( | |||
| github.com/gorilla/websocket v1.5.0 | |||
| github.com/gosuri/uilive v0.0.4 | |||
| github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 | |||
| github.com/hashicorp/consul v1.7.8 | |||
| // TODO: replace this with our own helper | ||
| "github.com/hashicorp/consul/sdk/testutil/retry" |
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Nomad's original autopilot was importing from a private package in Consul. It
has been moved out to a shared library. Switch Nomad to use this library so that
we can eliminate the import of Consul, which is necessary to build Nomad ENT
with the current version of the Consul SDK. This also will let us pick up
autopilot improvements shared with Consul more easily.
Fixes #9570 (associated with https://github.com/hashicorp/nomad-enterprise/pull/836)