fix: Add the missing option propagation_mode

[shumin1027]

Fix:#15524
Add the missing option propagation_mode

[hashicorp-cla]

All committers have signed the CLA.

[tgross]

Hi @shumin1027! I've tested this out with a host volume and the following jobspec:

jobspec

job "httpd" {
  datacenters = ["dc1"]

  group "web" {

    volume "host_data" {
      type      = "host"
      read_only = false
      source    = "shared_data"
    }

    task "http" {

      driver = "docker"

      config {
        image   = "busybox:1"
        command = "httpd"
        args    = ["-v", "-f", "-p", "8001", "-h", "/var/www"]
      }

      volume_mount {
        volume      = "host_data"
        destination = "/var/www"
        read_only   = false
        propagation_mode = "bidirectional"
      }

      resources {
        cpu    = 128
        memory = 128
      }

    }
  }
}

I changed the mode to private and host-to-task and got the expected mappings for the resulting Docker container.

So that looks good. This PR needs a couple more things before we can merge it:

• Run make cl which will create a changelog file for this PR.
• We need to add the propagation_mode field to the volume_mount docs, which you can edit in volume_mount.mdx

Thanks for the PR!

[shumin1027]

@tgross Thanks for your guidance, I've updated the docs and the changelog

[tgross]

LGTM

[twix14]

wasn't this supposed to be backported into 1.4.x, 1.3.x and 1.2.x? Latest release of all those doesn't contain this fix

[jrasell]

wasn't this supposed to be backported into 1.4.x, 1.3.x and 1.2.x? Latest release of all those doesn't contain this fix

Hi @twix14; the last release was a security release and therefore the only changes included were those specific to the required security patches. This changes will therefore go out in the next release train, which will coincide with the 1.5.0 GA.