Set the requested PropagationMode for volumes #15817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have disabled docker volumes in our Nomad clients to force users to have to
use host volumes since these are better controlled using ACL's.
For running cadvisor we need to expose the docker data directory to cadvisor, we
do this by allowing the cadvisor job to mount a host volume with the docker data
path and set propagationmode to "host-to-task" (rslave) as docker requires this,
see error:
```
failed to create container:
API error (400):
invalid mount config:
must use either propagation mode "rslave" or "rshared" when mount source is within the daemon root
```
Currently this wasn't applied for Host nor CSI volume mounts and I don't know why.
This MR enables the option for both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have disabled docker volumes in our Nomad clients to force users to have to use host volumes since these are better controlled using ACL's.
For running cadvisor we need to expose the docker data directory to cadvisor, we do this by allowing the cadvisor job to mount a host volume with the docker data path and set propagationmode to "host-to-task" (rslave) as docker requires this, see error:
Currently this wasn't applied for Host nor CSI volume mounts and I don't know why. This MR enables the option for both.