Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the requested PropagationMode for volumes #15817

Closed
wants to merge 1 commit into from
Closed

Set the requested PropagationMode for volumes #15817

wants to merge 1 commit into from

Commits on Jan 18, 2023

  1. Set the requested PropagationMode for volumes 

    We have disabled docker volumes in our Nomad clients to force users to have to
use host volumes since these are better controlled using ACL's.

For running cadvisor we need to expose the docker data directory to cadvisor, we
do this by allowing the cadvisor job to mount a host volume with the docker data
path and set propagationmode to "host-to-task" (rslave) as docker requires this,
see error:

```
failed to create container:
  API error (400):
    invalid mount config:
      must use either propagation mode "rslave" or "rshared" when mount source is within the daemon root
```

Currently this wasn't applied for Host nor CSI volume mounts and I don't know why.
This MR enables the option for both.
    @ygersie
    ygersie committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    219534f View commit details
    Browse the repository at this point in the history