services: ensure task group is set on service hook #16240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug where the task group information was not being set on the serviceHook.AllocInfo struct, which is needed later on for calculating the CheckID of a nomad service check. The CheckID is calculated independently from multiple callsites, and the information being passed in must be consistent, including the group name. The workload.AllocInfo.Group was not set at this callsite, due to the bug fixed in this PR. https://github.com/hashicorp/nomad/blob/main/client/serviceregistration/nsd/nsd.go#L114
shoenig
force-pushed
the
b-check-not-found
branch
from
96532e0
to
365f26f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the task group information was not being set
on the
serviceHook.AllocInfostruct, which is needed later on for calculatingthe
CheckIDof a nomad service check. TheCheckIDis calculated independentlyfrom multiple callsites, and the information being passed in must be consistent,
including the group name.
The
workload.AllocInfo.Groupwas not set at this callsite, due to the bug fixed in this PR.https://github.com/hashicorp/nomad/blob/main/client/serviceregistration/nsd/nsd.go#L114
Fixes #16238
I suspect the bug was introduced as part of #14311
Backport only to 1.4.x (when NSD checks were introduced).