Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update go-bexpr from 0.1.11 to 0.1.12 #16991

Merged
merged 2 commits into from
Apr 27, 2023
Merged

deps: update go-bexpr from 0.1.11 to 0.1.12 #16991

merged 2 commits into from
Apr 27, 2023

Conversation

schmichael
Copy link
Member

@schmichael schmichael commented Apr 26, 2023 •
edited
Loading

Pulls in hashicorp/go-bexpr#38

Fixes #16758

Without this fix in the bexpr the test fails with:

=== RUN   TestNode_List_PaginationFiltering/filter_on_meta_key
    node_endpoint_test.go:4420:
                Error Trace:    /home/schmichael/src/nomad/nomad/node_endpoint_test.go:4420
                Error:          Received unexpected error:
                                RPC Error:: 400,failed to read result page: error finding value in datum: /Meta/foo at part 1: couldn't find key "foo"
                Test:           TestNode_List_PaginationFiltering/filter_on_meta_key

jrasell
jrasell approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schmichael schmichael added backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line labels Apr 27, 2023
@schmichael schmichael merged commit 3dd9326 into main Apr 27, 2023
@schmichael schmichael deleted the b-missing-map-key branch April 27, 2023 16:01
This was referenced Apr 27, 2023
Closed
Merged
Merged
schmichael added a commit that referenced this pull request May 1, 2023
@schmichael
deps: update go-bexpr from 0.1.11 to 0.1.12 (#16991)
af7af35 
Pulls in hashicorp/go-bexpr#38

Fixes #16758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees
No one assigned
Labels
backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic metadata filter not working as described
2 participants
@schmichael @jrasell