[17070] Correct the status description and modify time of canceled evals. #17071
Conversation
Ensure modification time of completed and canceled evaluations is the same Co-authored-by: Tim Gross <tgross@hashicorp.com>
|
It seems that the tests failed on unrelated test cases. I don't seem to have the permission to rerun them. Do you mind kicking it off for me (feel free to tell me I'm wrong and direct me to the right UI -- I am not confident that I am looking at the right place) |
Done. The failed test is a known flake we've got another issue open to fix in progress. |
jrasell
added
backport/1.3.x
There was a problem hiding this comment.
LGTM and thanks @stswidwinski!
Would you be able to run make cl to add a changelog entry for this fix; with that I will get this merged.
… of github.com:stswidwinski/nomad into 17070-canceled_evaluation_provides_circular_debug_info
|
All done. Thank you! |
|
Backport assistant screwed up all the backports. I'll do those by hand. |
Fix for #17070. Corrected the status description and modify time of evals which are canceled due to another eval having completed in the meantime.
Tests added. It seems that the testing has originally been written a rather long time before the new-style of testing started within the Nomad codebase. Please let me know if you'd rather I moved the entire test to the new style, or if added if clauses seem like a reasonable tradeoff given the size of the change.