CLI: make snapshot name requiered in creating volume snapshots #17958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yazdan
commented
Jul 16, 2023
yazdan
commented
- Make snapshot name argument requiered
- Update documentation and helps
|
|
jrasell
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Hi @yazdan and thanks for raising this PR. I have added some inline comments and suggestions; please let me know if you have any follow up questions.
It would be good to add a changelog entry for this also. The make cl command can guide you through this.
- Make snapshot name argument requiered - Update documentation and helps
yazdan
force-pushed
the
make-volume-snapshot-name-required
branch
from
65ba808
to
f274147
Compare
|
@jrasell done, please review again. |
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
|
@jrasell done! |
jrasell
added
backport/1.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.