Update gopsutil to stop calling SetEnv #3041
Conversation
schmichael
changed the title
| } | ||
| sysctl, err := exec.LookPath("/sbin/sysctl") | ||
| if err != nil { | ||
| return []string{}, err | ||
| } | ||
| out, err := exec.Command(sysctl, "-n", mib).Output() | ||
| cmd := exec.Command(sysctl, "-n", mib) | ||
| cmd.Env = hostEnv |
There was a problem hiding this comment.
Since you're setting the execution environment for just the sysctl call, wouldn't it be easier to just always override with LC_ALL=C? The locale change has limited scope and should not affect Nomad executor. In fact, the original code was done to avoid any possible locale-induced parsing problem, so LC_ALL=C is a desirable thing.
There was a problem hiding this comment.
I'm not sure I understand what you're trying to say. This change sets LC_ALL=C just for this subprocess that needs it instead of setting it globally and having unintentional side effects.
schmichael
changed the title
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Pulls in shirou/gopsutil#417
Fixes #3036