Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented change to minimum cpu allocation in job spec #3709

Closed
comebackoneyear opened this issue Jan 3, 2018 · 3 comments
Closed

Undocumented change to minimum cpu allocation in job spec #3709

comebackoneyear opened this issue Jan 3, 2018 · 3 comments

Comments

@comebackoneyear
Copy link

comebackoneyear commented Jan 3, 2018 •
edited

Nomad version

Nomad v0.7.1

Operating system and Environment details

Ubuntu 16.04

Issue

The lower limit for cpu allocation for a job used to be 20, now it is 100
Seems to have been introduced by #3536

Reproduction steps

Deploy a job with a Cpu allocation of less than 100

Nomad Client logs (if appropriate)

Unexpected response code: 500 (1 error(s) occurred:

  • Task group test validation failed: 1 error(s) occurred:
  • Task test-beat validation failed: 1 error(s) occurred:
  • 1 error(s) occurred:
  • minimum CPU value is 100; got 94)

Job file (if appropriate)

...
        "Resources": {
                            "CPU": 94,
...
@comebackoneyear
Copy link
Author

Just found #3706 that seems to address this issue

@chelseakomlo
Copy link
Contributor

Closing as #3706 has merged.

paddycarver added a commit to hashicorp/terraform-provider-nomad that referenced this issue Jan 29, 2018
@paddycarver
Increase the test job's cpu.
0d4db21 
Nomad 0.7.1 had an accidental backwards compatibility break and
increased the minimum CPU allocation allowed in the job spec. What was
previously 20 is now 100. This was reported at hashicorp/nomad#3709.

This breaks our tests, which had a CPU allocation of 20. This PR just
increases them to 100, which allows the tests to pass again.

A fix (hashicorp/nomad#3706) has been merged, and will be part of the
next release, but I think it's worthwhile to change our tests and avoid
contributors stumbling into this on their own when running against
0.7.1, even if it'll work again in the next version of Nomad.
@paddycarver paddycarver mentioned this issue Jan 29, 2018
Merged
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chelseakomlo @comebackoneyear