Increase the test job's cpu. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nomad 0.7.1 had an accidental backwards compatibility break and increased the minimum CPU allocation allowed in the job spec. What was previously 20 is now 100. This was reported at hashicorp/nomad#3709. This breaks our tests, which had a CPU allocation of 20. This PR just increases them to 100, which allows the tests to pass again. A fix (hashicorp/nomad#3706) has been merged, and will be part of the next release, but I think it's worthwhile to change our tests and avoid contributors stumbling into this on their own when running against 0.7.1, even if it'll work again in the next version of Nomad.
paddycarver
requested review from
bflad,
tombuildsstuff,
mbfrahry and
vancluever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad 0.7.1 had an accidental backwards compatibility break and
increased the minimum CPU allocation allowed in the job spec. What was
previously 20 is now 100. This was reported at hashicorp/nomad#3709.
This breaks our tests, which had a CPU allocation of 20. This PR just
increases them to 100, which allows the tests to pass again.
A fix (hashicorp/nomad#3706) has been merged, and will be part of the
next release, but I think it's worthwhile to change our tests and avoid
contributors stumbling into this on their own when running against
0.7.1, even if it'll work again in the next version of Nomad.