Denormalize jobs in plan and ignore resources of terminal allocs #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
changed the title
Denormalize jobs in AppendAllocs: AppendAlloc was originally only ever called for inplace upgrades and new allocations. Both these code paths would remove the job from the allocation. Now we use this to also add fields such as FollowupEvalID which did not normalize the job. This is only a performance enhancement. Ignore terminal allocs: Failed allocations are annotated with the followup Eval ID when one is created to replace the failed allocation. However, in the plan applier, when we check if allocations fit, these terminal allocations were not filtered. This could result in the plan being rejected if the node would be overcommited if the terminal allocations resources were considered.
dadgar
changed the title
schmichael
approved these changes
Sep 24, 2018
| @@ -7138,6 +7141,10 @@ func (p *Plan) PopUpdate(alloc *Allocation) { | |||
| func (p *Plan) AppendAlloc(alloc *Allocation) { | |||
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denormalize jobs in AppendAllocs
AppendAlloc was originally only ever
called for inplace upgrades and new allocations. Both these code paths
would remove the job from the allocation. Now we use this to also add
fields such as FollowupEvalID which did not normalize the job. This is only
a performance enhancement.
Ignore terminal allocs
Failed allocations are annotated with the followup
Eval ID when one is created to replace the failed allocation. However, in
the plan applier, when we check if allocations fit, these terminal
allocations were not filtered. This could result in the plan being rejected
if the node would be overcommited if the terminal allocations resources
were considered.
Builds on #4709