-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constraint numeric comparison #4729
Comments
I changed the title of the issue. Constraints are compared lexicographically. We should parse it as a number if possible however. Marking as an enhancement |
Thanks, but according to your comment it looks like a bug... |
Is there any hope to get it fixed? |
It looks like @MrJacek has a patch here MrJacek@74e43fe that was never submitted as a PR. I wonder if we could get him to submit that? |
It was submitted as a PR in 4856 but rejected :) |
Ah, I see that now. It does look like this should be supported following #4783 where attributes get parsed into numbers, but I just verified it's still lexicographically sorting the constraints. I'll dig into this because the behavior seems like a gotcha even if it's documented. |
Thanks, @tgross. I agree that documenting this bug is not enough. It should be fixed as current behaviour is illogical, counter-intuitive and potent to cause very undesirable placement issues. It does not seem to be a difficult technical issue to fix, right? |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
For some reason job with
Is placed to machines with
cpu.numcores == 8
.Why? Even if constraints are not mandatory but merely advisory a job should have been placed to client with 10+ cores, right?
The text was updated successfully, but these errors were encountered: