Device constraint checking #4783
Conversation
| }, | ||
| }, | ||
| } | ||
|
|
scheduler/feasible.go
Outdated
| return false | ||
| } | ||
| return checkRegexpMatch(ctx, ls, rs) | ||
| case structs.ConstraintSetContains: |
There was a problem hiding this comment.
Should we also add support for ConstraintSetContainsAny here? (we've wanted to do so since affinities introduced it, but haven't gotten around to it, might as well do it now.)
| NodeDevices: []*structs.NodeDeviceResource{nvidia, intel}, | ||
| RequestedDevices: []*structs.RequestedDevice{gpuTypeHighCountReq}, | ||
| }, | ||
| { |
There was a problem hiding this comment.
maybe add another test like this with multiple constraints and count > 1
scheduler/feasible.go
Outdated
| return psstructs.NewStringAttribute(d.Type), true | ||
|
|
||
| case strings.HasPrefix(target, "${driver.attr."): | ||
| attr := strings.TrimSuffix(strings.TrimPrefix(target, "${driver.attr."), "}") |
There was a problem hiding this comment.
would split this into two lines for readability
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR:
Builds on top of #4780