Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] add brackets to links with IPv6 addresses #5966

Closed
pznamensky opened this issue Jul 16, 2019 · 5 comments
Closed

[UI] add brackets to links with IPv6 addresses #5966

pznamensky opened this issue Jul 16, 2019 · 5 comments

Comments

@pznamensky
Copy link

Nomad version

Nomad v0.9.3 (c5e8b66)

Issue

When a service registered on IPv6 interface nomad doesn't add bracket to the link
Screenshot_20190716_193638

Wrong: http://2000:a:b:c::d:80
Correct: http://[2000:a:b:c::d]:80

Reproduction steps

Create a job with service which register on IPv6 address.
View links in UI.

@backspace
Copy link
Contributor

Thanks for letting us know about this! I have a PR for this, which you can try out here against a mock API.

@pznamensky
Copy link
Author

Good news! Thank you!

backspace added a commit that referenced this issue Jul 30, 2019
@backspace
Copy link
Contributor

I ended up using a different approach, but it’s now merged, and should be released as part of version 0.9.5. 😀

@pznamensky
Copy link
Author

Thanks!

notnoop pushed a commit that referenced this issue Aug 13, 2019
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants