UI: Add IPv6 bracket-wrapping to network serializer #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backspace
changed the title
notnoop
approved these changes
Jul 29, 2019
backspace
added a commit
that referenced
this pull request
Jul 29, 2019
Thanks to @notnoop for letting me know about this: #6007 (comment)
# Conflicts: # CHANGELOG.md
DingoEatingFuzz
approved these changes
Jul 30, 2019
schmichael
added a commit
that referenced
this pull request
Aug 1, 2019
notnoop
pushed a commit
that referenced
this pull request
Aug 13, 2019
This addresses the issue raised by @pznamensky in #5966.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more-foundational approach than #5992, which removes any need to change templates and ensures that the IPv6 address will be properly wrapped anywhere it’s used.
I didn’t include anything other than serialiser tests as the acceptance tests and Mirage needed a lot of reorganising to permit the assertions in #5992, but if that seems important, I can port them here.