-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set Docker labels for sidecar tasks #7991
Comments
So, after a while (hours), labels started to show up in the output of Now, when I changed the labels, stopped the job, then ran it again, I still kept seeing the old labels. Are the sidecar task custom labels cached, perhaps? |
Thanks for reporting @akhayyat ! At first guess, I suspect we're not properly identifying when the opaque |
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes hashicorp#8596 hashicorp#7991 Non-destructive half in hashicorp#7192
Closed by #9029 and shipped in 1.0.0 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.11.1 (b434570)
Operating system and Environment details
Debian 10.3
Issue
Setting Docker labels for
sidecar_task
has no effect. The envoy sidecar containers do not have the configured labels. Docker labels work fine on normal tasks.Reproduction steps
Run a Docker job with some Docker labels defined under
service.connect.sidecar_task.config.labels
. See below for an example.Job file (if appropriate)
Nomad Client logs (if appropriate)
Nothing special.
The text was updated successfully, but these errors were encountered: