-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing a service port doesn't trigger an update #8596
Comments
shoenig
added a commit
that referenced
this issue
Oct 5, 2020
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
shoenig
added a commit
that referenced
this issue
Oct 5, 2020
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
shoenig
added a commit
that referenced
this issue
Oct 5, 2020
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes #8596 #7991 Non-destructive half in #7192
fredrikhgrelland
pushed a commit
to fredrikhgrelland/nomad
that referenced
this issue
Oct 22, 2020
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes hashicorp#8596 hashicorp#7991 Non-destructive half in hashicorp#7192
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
jorgemarey
pushed a commit
to jorgemarey/nomad
that referenced
this issue
Nov 1, 2023
This PR fixes a long standing bug where submitting jobs with changes to connect services would not trigger updates as expected. Previously, service blocks were not considered as sources of destructive updates since they could be synced with consul non-destructively. With Connect, task group services that have changes to their connect block or to the service port should be destructive, since the network plumbing of the alloc is going to need updating. Fixes hashicorp#8596 hashicorp#7991 Non-destructive half in hashicorp#7192
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Nomad version
0.12.1 (also tested on 0.11.0 and 0.10.0)
Operating system and Environment details
Ubuntu
Issue
Changing the
port
value for aservice
doesn't trigger a new allocation, resulting in a situation where user changes are not actually applied.Reproduction steps
count-api
serviceapi
doesn't change)Expected result
Countdash displays a connection error message.
Observed result
Countdash still works.
The text was updated successfully, but these errors were encountered: