Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing a service port doesn't trigger an update #8596

Closed
lgfa29 opened this issue Aug 5, 2020 · 1 comment · Fixed by #9029
Closed

Changing a service port doesn't trigger an update #8596

lgfa29 opened this issue Aug 5, 2020 · 1 comment · Fixed by #9029
Assignees
@shoenig
Labels
stage/needs-investigation theme/consul type/bug

Comments

@lgfa29
Copy link
Contributor

lgfa29 commented Aug 5, 2020

Nomad version

0.12.1 (also tested on 0.11.0 and 0.10.0)

Operating system and Environment details

Ubuntu

Issue

Changing the port value for a service doesn't trigger a new allocation, resulting in a situation where user changes are not actually applied.

Reproduction steps

  1. Run countdash
  2. Check that it's running properly on http://localhost:9002
  3. Comment out the port for the count-api service
    service {
      name = "count-api"
-      port = "9001"
+      # port = "9001"
  1. Run the job again (notice that the allocation ID for api doesn't change)
  2. Check http://localhost:9002 again.

Expected result

Countdash displays a connection error message.

Observed result

Countdash still works.
@shoenig shoenig self-assigned this Oct 5, 2020
shoenig added a commit that referenced this issue Oct 5, 2020
@shoenig
consul/connect: modifying connect services should trigger updates
6a4418c 
This PR fixes a long standing bug where submitting jobs with changes
to connect services would not trigger updates as expected. Previously,
service blocks were not considered as sources of destructive updates
since they could be synced with consul non-destructively. With Connect,
task group services that have changes to their connect block or to
the service port should be destructive, since the network plumbing of
the alloc is going to need updating.

Fixes #8596 #7991

Non-destructive half in #7192
shoenig added a commit that referenced this issue Oct 5, 2020
@shoenig
consul/connect: modifying connect services should trigger updates
4224be9 
This PR fixes a long standing bug where submitting jobs with changes
to connect services would not trigger updates as expected. Previously,
service blocks were not considered as sources of destructive updates
since they could be synced with consul non-destructively. With Connect,
task group services that have changes to their connect block or to
the service port should be destructive, since the network plumbing of
the alloc is going to need updating.

Fixes #8596 #7991

Non-destructive half in #7192
shoenig added a commit that referenced this issue Oct 5, 2020
@shoenig
consul/connect: trigger update as necessary on connect changes
37cd0ec 
This PR fixes a long standing bug where submitting jobs with changes
to connect services would not trigger updates as expected. Previously,
service blocks were not considered as sources of destructive updates
since they could be synced with consul non-destructively. With Connect,
task group services that have changes to their connect block or to
the service port should be destructive, since the network plumbing of
the alloc is going to need updating.

Fixes #8596 #7991

Non-destructive half in #7192
@shoenig shoenig mentioned this issue Oct 5, 2020
Merged
fredrikhgrelland pushed a commit to fredrikhgrelland/nomad that referenced this issue Oct 22, 2020
@shoenig @fredrikhgrelland
consul/connect: trigger update as necessary on connect changes
628c5ba 
This PR fixes a long standing bug where submitting jobs with changes
to connect services would not trigger updates as expected. Previously,
service blocks were not considered as sources of destructive updates
since they could be synced with consul non-destructively. With Connect,
task group services that have changes to their connect block or to
the service port should be destructive, since the network plumbing of
the alloc is going to need updating.

Fixes hashicorp#8596 hashicorp#7991

Non-destructive half in hashicorp#7192
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
jorgemarey pushed a commit to jorgemarey/nomad that referenced this issue Nov 1, 2023
@shoenig @jorgemarey
consul/connect: trigger update as necessary on connect changes
ab4b427 
This PR fixes a long standing bug where submitting jobs with changes
to connect services would not trigger updates as expected. Previously,
service blocks were not considered as sources of destructive updates
since they could be synced with consul non-destructively. With Connect,
task group services that have changes to their connect block or to
the service port should be destructive, since the network plumbing of
the alloc is going to need updating.

Fixes hashicorp#8596 hashicorp#7991

Non-destructive half in hashicorp#7192
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/needs-investigation theme/consul type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consul/connect: trigger update as necessary on connect changes hashicorp/nomad
3 participants
@shoenig @lgfa29 @tgross