Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Consul failures_before_critical and success_before_passing in check stanza #8506

Closed
scalp42 opened this issue Jul 22, 2020 · 2 comments
Labels
theme/consul/connect Consul Connect integration theme/dependencies Pull requests that update a dependency file

Comments

@scalp42
Copy link
Contributor

scalp42 commented Jul 22, 2020

Hi folks,

It'd be great if Nomad could support new Consul 1.7.x features that were merged (hashicorp/consul#5739).

See also https://www.consul.io/docs/agent/checks.html#success-failures-before-passing-critical

Thanks 🙏

@shoenig
Copy link
Member

shoenig commented Jul 22, 2020

Thanks for reporting, @scalp42 !

We've already got an issue tracking this in #6913. Before Nomad can use these features, there's a fix that recently got merged into Consul in hashicorp/consul#7949 that still needs to go out in an official Consul release. We'll track in that first Nomad ticket when the feature becomes available via Nomad.

@shoenig shoenig closed this as completed Jul 22, 2020
@shoenig shoenig added theme/consul/connect Consul Connect integration theme/dependencies Pull requests that update a dependency file labels Jul 22, 2020
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/consul/connect Consul Connect integration theme/dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants