Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Consul 1.7 consecutive pass/fail on health checks #6913

Closed
tgross opened this issue Jan 8, 2020 · 5 comments
Closed

Support Consul 1.7 consecutive pass/fail on health checks #6913

tgross opened this issue Jan 8, 2020 · 5 comments
Assignees
@shoenig
Labels
theme/consul theme/dependencies Pull requests that update a dependency file

Comments

@tgross
Copy link
Member

tgross commented Jan 8, 2020

Consul 1.7 provides support for configuring health checks to become passing/critical only if a specified number of consecutive checks return passing/critical. Nomad service health check config should also allow this configuration.
@tgross tgross added theme/consul theme/dependencies Pull requests that update a dependency file labels Jan 8, 2020
@tgross tgross modified the milestones: near-term, unscheduled Jan 8, 2020
@shoenig shoenig self-assigned this Mar 9, 2020
@shoenig shoenig modified the milestones: unscheduled , 0.11.1 Apr 15, 2020
@tgross tgross modified the milestones: 0.11.1, 0.11.2 Apr 22, 2020
@tgross tgross removed this from the 0.11.2 milestone May 13, 2020
@shantanugadgil
Copy link
Contributor

What ... postponed again! 😭

@shoenig
Copy link
Member

shoenig commented May 15, 2020

Sorry about the postponement @shantanugadgil , this is blocked by
hashicorp/consul#7764
(Consul does not currently accept configuration of these fields via HTTP API)

@shoenig shoenig mentioned this issue May 22, 2020
Merged
@shoenig shoenig mentioned this issue Jul 22, 2020
Closed
@shoenig
Copy link
Member

shoenig commented Jul 31, 2020 •
edited
Loading

Looks like hashicorp/consul#7949 got merged for Consul v1.8.1, however we still need an updated api/ version to import from Nomad.

shoenig added a commit that referenced this issue Aug 7, 2020
@shoenig
deps: upgrade import of consul/api
7d81607 
Upgrade our consul/api import to the equivelent of consul@v1.8.1 which includes
a bug fix necessary for #6913. If consul would publish a proper api/ submodule tag
we could reference that.
@shoenig shoenig mentioned this issue Aug 7, 2020
Merged
shoenig added a commit that referenced this issue Aug 7, 2020
@shoenig
deps: upgrade import of consul/api
7bdbef2 
Upgrade our consul/api import to the equivelent of consul@v1.8.1 which includes
a bug fix necessary for #6913. If consul would publish a proper api/ submodule tag
we could reference that.
shoenig added a commit that referenced this issue Aug 10, 2020
@shoenig
consul: able to set pass/fail thresholds on consul service checks
9424c55 
This change adds the ability to set the fields `success_before_passing` and
`failures_before_critical` on Consul service check definitions. This is a
feature added to Consul v1.7.0 and later.
  https://www.consul.io/docs/agent/checks#success-failures-before-passing-critical

Nomad doesn't do much besides pass the fields through to Consul.

Fixes #6913
@shantanugadgil
Copy link
Contributor

🎉

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/consul theme/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shoenig @tgross @shantanugadgil