api/agent: enable setting check thresholds in agent API #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ical in API Fixes #7764 Until now these two fields could only be set through on-disk agent configuration. This change adds the fields to the agent API struct definition so that they can be set using the agent HTTP API.
hanshasselberg
approved these changes
Jun 29, 2020
hanshasselberg
deleted the
b-add-check-thresholds-to-agent-check-registration
branch
|
🍒✅ Cherry pick of commit 95f46eb onto |
|
did this make it into Consul 1.8.1 ? (asking as I am unsure by just looking at the CHANGELOG) :) |
|
@shantanugadgil Yes, it did make it into 1.8.1. Here's the relevant commit (8700976) on the release/1.8.1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/agent: enable setting SuccessBeforePassing and FailuresBeforeCritical in API
Fixes #7764
Needed by hashicorp/nomad#6913
Until now these two fields could only be set through on-disk agent configuration.
This change adds the fields to the agent API struct definition so that they can
be set using the agent HTTP API.