Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Keep-alive setting for remote exec UI #8727

Closed
jfcantu opened this issue Aug 24, 2020 · 2 comments · Fixed by #8759
Closed

Feature request: Keep-alive setting for remote exec UI #8727

jfcantu opened this issue Aug 24, 2020 · 2 comments · Fixed by #8759
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement

Comments

@jfcantu
Copy link

jfcantu commented Aug 24, 2020

Hey folks,

Simple (hopefully?) feature request for the Nomad remote exec web UI:

We run our Nomad cluster behind an AWS application load balancer that serves the UI and API. The ALB has a connection idle timeout, which by default is 60 seconds. So, basically, if you open a remote exec session, it will only stay open as long as there's either input or output from the session - otherwise, it terminates after the timeout expires.

It would be helpful for Nomad to have a "keep-alive" function for exec sessions to prevent issues like this.
@backspace backspace self-assigned this Aug 25, 2020
@backspace backspace removed their assignment Aug 25, 2020
@backspace
Copy link
Contributor

Thanks for the suggestion, @jfcantu. It does seem simple enough to implement in the UI, though I’m wondering if it should have CLI support as well, then both consumers could use the same flag. I’ll ask around about this.

backspace added a commit that referenced this issue Aug 27, 2020
@backspace
Add exec heartbeat keepalive
d390268 
This closes #8727, thanks to @jfcantu for the suggestion.
The CLI implementation of exec already has a 10-second
heartbeat so this mirrors that:
https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
@backspace backspace mentioned this issue Aug 27, 2020
Merged
@backspace backspace added stage/accepted Confirmed, and intend to work on. No timeline committment though. and removed stage/needs-discussion labels Aug 27, 2020
backspace added a commit that referenced this issue Aug 28, 2020
@backspace
Add exec heartbeat keepalive
ac77b11 
This closes #8727, thanks to jfcantu for the suggestion.
The CLI implementation of exec already has a 10-second
heartbeat so this mirrors that:
https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
backspace added a commit that referenced this issue Aug 28, 2020
@backspace
Add exec heartbeat keepalive (#8759)
0c9b2e4 
This closes #8727, thanks to @jfcantu for the suggestion.
The CLI implementation of exec already has a 10-second
heartbeat so this mirrors that:
https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/ui type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI: Add exec heartbeat keepalive hashicorp/nomad
2 participants
@backspace @jfcantu