UI: Add exec heartbeat keepalive #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 037870f Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
backspace
force-pushed
the
f-ui/exec-keepalive
branch
from
42fa39c
to
d390268
Compare
DingoEatingFuzz
approved these changes
Aug 27, 2020
This closes #8727, thanks to jfcantu for the suggestion. The CLI implementation of exec already has a 10-second heartbeat so this mirrors that: https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
backspace
force-pushed
the
f-ui/exec-keepalive
branch
from
d390268
to
ac77b11
Compare
|
Four days. Four days from my making the suggestion, to having it implemented and merged to Thank you all! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #8727, thanks to @jfcantu for the suggestion.
The CLI implementation of exec already has a 10-second
heartbeat so this mirrors that:
https://github.com/hashicorp/nomad/blob/v0.12.3/api/allocations.go#L161-L173
Here’s a GIF showing the
{}message being sent after 10 seconds: