-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify node drain deadline interaction with task kill_timeout #9902
Labels
Projects
Milestone
Comments
This was referenced Aug 30, 2022
This was referenced Apr 12, 2023
Closed by #16823: the |
This was referenced Apr 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
node drain
doc indicates that allocations still remaining after deadline will be forced removed from the node. This hint that the allocations will be killed quickly, yet in practice the allocations are signaled to shutdown and wait the entirekill_timeout
interval before stopping and the replacement alloc stopped.We ought to clarify what the expected behavior is, document it, and/or fix it if we decide that current behavior is lacking. Also, update nodedrain e2e tests disabled in #9903.
Steps
nomad node drain enable -enable -deadline 10s -yes <node_id_where_alloc_fall>
Sample script output
The text was updated successfully, but these errors were encountered: