Backport of E2E: clarify drain -deadline
and -force
flag behaviors into release/1.4.x
#16870
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16868 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
The
-deadline
and-force
flag for thenomad node drain
command only cause the draining to ignore themigrate
block's healthy deadline, max parallel, etc. These flags don't have anything to do with thekill_timeout
orshutdown_delay
options of the jobspec.This changeset fixes the skipped E2E tests so that they validate the intended behavior, and updates the docs for more clarity.
Extracted from #14348
Fixes #9902