Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul/connect: Fix bug where connect sidecar services would be unnecessarily re-registered #10059

Merged
merged 1 commit into from
Feb 22, 2021

Commits on Feb 22, 2021

  1. consul/connect: Fix bug where connect sidecar services would be unnec…

    …essarily re-registered
    
    This PR fixes a bug where sidecar services would be re-registered into Consul every ~30
    seconds, caused by the parent service having its tags field set and the sidecar_service
    tags unset. Nomad would directly compare the tags between its copy of the sidecar service
    definition and the tags of the sidecar service reported by Consul. This does not work,
    because Consul will under-the-hood set the sidecar service tags to inherit the parent
    service tags if the sidecar service tags are unset. The comparison then done by Nomad
    would not match, if the parent sidecar tags are set.
    
    Fixes #10025
    shoenig committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e3af469 View commit details
    Browse the repository at this point in the history