-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Change global search to use fuzzy search API #10412
Merged
Merged
Commits on Apr 20, 2021
-
Remove running client-side search tests for now
I’ll delete these later after I’ve replaced them.
Configuration menu - View commit details
-
Copy full SHA for 885a592 - Browse repository at this point
Copy the full SHA 885a592View commit details -
Configuration menu - View commit details
-
Copy full SHA for 601d1a6 - Browse repository at this point
Copy the full SHA 601d1a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 555ba2d - Browse repository at this point
Copy the full SHA 555ba2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4501e44 - Browse repository at this point
Copy the full SHA 4501e44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d5fdf2 - Browse repository at this point
Copy the full SHA 7d5fdf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5beff76 - Browse repository at this point
Copy the full SHA 5beff76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ce3cb3 - Browse repository at this point
Copy the full SHA 8ce3cb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dadcad - Browse repository at this point
Copy the full SHA 3dadcadView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf488fa - Browse repository at this point
Copy the full SHA cf488faView commit details
Commits on Apr 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2865773 - Browse repository at this point
Copy the full SHA 2865773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a6b1a1 - Browse repository at this point
Copy the full SHA 4a6b1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c79952e - Browse repository at this point
Copy the full SHA c79952eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 85725f9 - Browse repository at this point
Copy the full SHA 85725f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd9d049 - Browse repository at this point
Copy the full SHA fd9d049View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f92a22 - Browse repository at this point
Copy the full SHA 9f92a22View commit details
Commits on Apr 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e3198a6 - Browse repository at this point
Copy the full SHA e3198a6View commit details -
Add guards against unrealistic random data
The search test was failing occasionally when showing allocations because of the lifecycle chart breaking. While I don’t think these exceptions would happen with real data, adding some guards seems okay.
Configuration menu - View commit details
-
Copy full SHA for abe2794 - Browse repository at this point
Copy the full SHA abe2794View commit details -
Fix wasteful reruns of application beforeModel
I noticed that the feature detection search was running whenever I navigated to a search result, it turns out that refreshModel on the region query parameter meant the application route was reloading on calls to service:router#transitionTo because the calls didn’t include the region query parameter. Rather than needing to add the region to every transitionTo call, this just lets the route load again but skips the various detection/setup queries.
Configuration menu - View commit details
-
Copy full SHA for a39c3b9 - Browse repository at this point
Copy the full SHA a39c3b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c5fe93 - Browse repository at this point
Copy the full SHA 3c5fe93View commit details -
Configuration menu - View commit details
-
Copy full SHA for d39f5a2 - Browse repository at this point
Copy the full SHA d39f5a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1a7b48 - Browse repository at this point
Copy the full SHA c1a7b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6fc44b - Browse repository at this point
Copy the full SHA d6fc44bView commit details -
Change context for feature detection query
It’s my belief that this is the most lightweight option.
Configuration menu - View commit details
-
Copy full SHA for 72d6200 - Browse repository at this point
Copy the full SHA 72d6200View commit details
Commits on Apr 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b370b94 - Browse repository at this point
Copy the full SHA b370b94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54346bc - Browse repository at this point
Copy the full SHA 54346bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2aa291 - Browse repository at this point
Copy the full SHA d2aa291View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.