-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Change global search to use fuzzy search API #10412
Changes from all commits
885a592
601d1a6
555ba2d
4501e44
7d5fdf2
5beff76
8ce3cb3
3dadcad
cf488fa
2865773
4a6b1a1
c79952e
85725f9
fd9d049
9f92a22
e3198a6
abe2794
a39c3b9
3c5fe93
d39f5a2
c1a7b48
d6fc44b
72d6200
b370b94
54346bc
d2aa291
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,10 @@ export default class LifecycleChartRow extends Component { | |
|
||
@computed('task.lifecycleName') | ||
get lifecycleLabel() { | ||
if (!this.task) { | ||
return ''; | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems unrelated. How'd you end up here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don’t totally understand but I was experiencing test failures when navigating to some search results and had to add a couple of null-handlings, I suspect it has something to do with the way the Mirage models are being constructed. With the time constraint I sadly just added the guards without digging further to grasp the underlying issue 😞 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's reasonable! |
||
const name = this.task.lifecycleName; | ||
|
||
if (name.includes('sidecar')) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really clean way to handle the API response shape.