Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul/connect: in-place update service definition when connect upstreams are modified #10776

Merged
merged 1 commit into from
Jun 17, 2021

Commits on Jun 16, 2021

  1. consul/connect: in-place update service definition when connect upstr…

    …eams are modified
    
    This PR fixes a bug where modifying the upstreams of a Connect sidecar proxy
    would not result Consul applying the changes, unless an additional change to
    the job would trigger a task replacement (thus replacing the service definition).
    
    The fix is to check if upstreams have been modified between Nomad's view of the
    sidecar service definition, and the service definition for the sidecar that is
    actually registered in Consul.
    
    Fixes #8754
    shoenig committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    7ba60b4 View commit details
    Browse the repository at this point in the history