Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-gopsutil, closes #10761 #10790

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

fredwangwang
Copy link
Contributor

update to include shirou/gopsutil#1088, fixes slow cpu info for windows platform. closes #10761

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 19, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM. Any chance we can encourage gopsutil folks to cut a release tag for this? We do have a history of pointing to specific commits but we try to avoid adding to that because it upsets downstream packagers.

@shoenig
Copy link
Member

shoenig commented Jun 21, 2021

Taged at every end of month, but there are only a few commits, it can be skipped.

@tgross I don't think we should wait, especially if we can get this into v1.1.2

@tgross
Copy link
Member

tgross commented Jun 21, 2021

I don't think we should wait, especially if we can get this into v1.1.2

Good call, let's merge it.

@tgross tgross merged commit df74bc0 into hashicorp:main Jun 21, 2021
@tgross tgross added this to the 1.1.2 milestone Jun 21, 2021
@fredwangwang fredwangwang deleted the update-gopsutil branch June 23, 2021 20:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fingerprinting Nomad Clients (on restart) on Windows and ESXI hosts can far exceed the heartbeat
4 participants