processor, v3/processor (Win): fix slow cpuinfo on multisocket config

[fredwangwang]

updated win32_Processor struct to exclude (unused) LoadPercentage field.
The loadpercentage takes linearly more time as the # of sockets
increases. By default vSphere maps 1 vCPU to 1 socket, resulting in very
poor performance when getting CPU info against, saying, 40 vCPU VM
(basically 40 sockets as seen by the VM).

Here is the before and after time comparison:

changes:

for cpu:
since Win32_Processor is a public struct, created a substruct named: Win32_ProcessorWithoutLoadPct for use in all queries without breaking any potential usage of the public api.

for v3/cpu:
since the struct now is private, simply removed LoadPercentage

[idrennanvmware]

@shirou - any chance we could prioritize this? This particular issue is trickling down through our usage of Nomad and in turn the long fingerprint times on our ESXI hosts are causing issues. Very much appreciate the work you've done, and our ability to contribute to this. If you need us to address anything on the PR please let us know and we will be happy to do so.

Thanks!

[shirou]

I can only have a time on weekends.

[idrennanvmware]

Totally understand. And ty again for all your hard work!

…

--- Sent from Workspace ONE Boxer<https://whatisworkspaceone.com/boxer> On June 17, 2021 at 7:21:50 PM EDT, shirou ***@***.***> wrote: I can only have a time on weekends. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fshirou%2Fgopsutil%2Fpull%2F1088%23issuecomment-863622662&data=04%7C01%7Cidrennan%40vmware.com%7C62308e275a8b459fc0ea08d931e6ae0e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637595689102413351%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3kApfW5g%2BRVxXn2mV%2FEPZIZhqp0jlpPTXM8Y%2B%2FOYxjE%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.luolix.top%2Fnotifications%2Funsubscribe-auth%2FALAO6CKNPVWVPPCSHNFKN23TTJ7QXANCNFSM46WNSJYA&data=04%7C01%7Cidrennan%40vmware.com%7C62308e275a8b459fc0ea08d931e6ae0e%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637595689102423303%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gepbhbcveocdOpcWchse039z5M6iWvYQ9zwleOFFOiI%3D&reserved=0>.

[shirou]

Thank you for your contribution and your patiant.

• As you mentioned, LoadPercentage is not used currently. so please just remove LoadPercentage without creating another struct?
• Could you also implement to v3 in same way?

[fredwangwang]

Hi @shirou thanks for reviewing!

See my comments above:

changes:

for cpu:
since Win32_Processor is a public struct, created a substruct named: Win32_ProcessorWithoutLoadPct for use in all queries without breaking any potential usage of the public api.

for v3/cpu:
since the struct now is private, simply removed LoadPercentage

However if you are fine with "breaking" the contract for cpu.Win32_Processor, I am more than happy to update the pr and simply remove LodaPercentage as well, pls let me know 🙂

[shirou]

Oh, OK, I understand. Then, it is a good implementation! Thank you so much!

[fredwangwang]

Hi @shirou looks like the shellcheck is the only part fails, but that feels unrelated to the pr's change. Could you help to take a look at that? Thank you!

[shirou]

some of the tests are stoled but mostly ok. So I merge this PR. Thank you!

[idrennanvmware]

Thanks so much @fredwangwang and @shirou !

[fredwangwang]

Hi @shirou is it possible to cut a new release? The downstream package consumer (hashicorp nomad) prefers a tagged build instead of using a specific sha.

Thanks in advance!

[shirou]

gopsutil will be released on end of month.

[fredwangwang]

Ty!

…

On Tue, Jun 22, 2021, 8:13 AM shirou ***@***.***> wrote: gopsutil will be released on end of month <https://github.com/shirou/gopsutil/#tag-semantics>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1088 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFFPT2KGHJPVT33MSKDEBITTUCLB5ANCNFSM46WNSJYA> .