Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat a failed recover + successful destroy as a successful recover #10849

Merged
merged 2 commits into from
Jul 19, 2021

Commits on Jul 3, 2021

  1. Don't treat a failed recover + successful destroy as a successful

    recover
    
    This code just seems incorrect. As it stands today it reports a
    successful restore if RecoverTask fails and then DestroyTask succeeds.
    
    This can result in a really annoying bug where it then calls RecoverTask
    again, whereby it will probably get ErrTaskNotFound and call DestroyTask
    once more.
    
    I think the only reason this has not been noticed so far is because most
    drivers like Docker will return Success, then nomad will call
    RecoverTask, get an error (not found) and call DestroyTask again, and
    get a ErrTasksNotFound err.
    Ben Buzbee committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    baea471 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Configuration menu
    Copy the full SHA
    f2fddc9 View commit details
    Browse the repository at this point in the history