Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat a failed recover + successful destroy as a successful recover #10849

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Don't treat a failed recover + successful destroy as a successful recover #10849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baea471
Don't treat a failed recover + successful destroy as a successful
Jul 3, 2021
f2fddc9
docs: add changelog entry for #10849
schmichael Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/10849.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
drivers: Fixed bug where Nomad incorrectly reported tasks as recovered successfully even when they were not.
```
3 changes: 1 addition & 2 deletions client/allocrunner/taskrunner/task_runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,10 +1136,9 @@ func (tr *TaskRunner) restoreHandle(taskHandle *drivers.TaskHandle, net *drivers
"error", err, "task_id", taskHandle.Config.ID)
}

return false
}

return true
return false
}

// Update driver handle on task runner
Expand Down