Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: Avoid assumption of parent service when filtering connect proxies #10872

Merged
merged 2 commits into from
Jul 8, 2021
Merged

consul/connect: Avoid assumption of parent service when filtering connect proxies #10872

merged 2 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. consul/connect: Avoid assumption of parent service when filtering con… 

    …nect proxies

This PR uses regex-based matching for sidecar proxy services and checks when syncing
with Consul. Previously we would check if the parent of the sidecar was still being
tracked in Nomad. This is a false invariant - one which we must not depend when we
make #10845 work.

Fixes #10843
    @shoenig
    shoenig committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    86283ad View commit details
    Browse the repository at this point in the history

  2. consul/connect: improve regex from CR suggestions

    @shoenig
    shoenig committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    82f4245 View commit details
    Browse the repository at this point in the history