Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit ember-can to add additional attribute for namespace #10893

Merged
merged 5 commits into from
Jul 22, 2021

Commits on Jul 13, 2021

  1. edit ember-can to add additional attribute for namespace

    We wanted the ability to get our namespace from query params
    in order to do this, we're using additional attributes via
    ember-can to set a bound property directly from our
    handlebar file. This sets us up better in the event that
    the namespace filter changes on the UI because our handlebar
    file will be aware of the change, whereas our ability may not
    update as the namespace filter updates.
    ChaiWithJai committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    d92261e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. refactoring for same regression in job versions

    In job versions, if you have an ACL token with a write policy
    you should be able to revert a job, however, that was not the
    case here. This is because we're using ember-can to check if
    the user can run a job. That permission relies on policiesSupportRunning
    which uses a function called namespaceIncludesCapability. We're going to
    need to refactor any cases that use this function.
    ChaiWithJai committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    b09559e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. address merge conflicts

    ChaiWithJai committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3e07db8 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Configuration menu
    Copy the full SHA
    18ddb2d View commit details
    Browse the repository at this point in the history
  2. ui: fixes #10885

    ChaiWithJai committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    65fd437 View commit details
    Browse the repository at this point in the history