Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: fix wildcard namespace handling #10935

Merged
merged 2 commits into from
Sep 2, 2021
Merged

events: fix wildcard namespace handling #10935

merged 2 commits into from
Sep 2, 2021

Commits on Jul 23, 2021

  1. events: fix wildcard namespace handling 

    This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard. When Nomad parses
incoming requests, it sets namespace to default if not specified, which
means the request namespace will never be an empty string, which is what
the event subscription was checking for. This changes the conditional
logic to check for a wildcard namespace instead of an empty one.

It also updates some event tests to include the default namespace in the
subscription to match current behavior.

Fixes #10903
    @isabeldepapel
    isabeldepapel committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    91f05cb View commit details
    Browse the repository at this point in the history

  2. Add changelog

    @isabeldepapel
    isabeldepapel committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    da0bbf9 View commit details
    Browse the repository at this point in the history