Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix linter and prettier #11754

Merged
merged 20 commits into from
Jan 24, 2022
Merged

ui: fix linter and prettier #11754

merged 20 commits into from
Jan 24, 2022

Conversation

ChaiWithJai
Copy link
Contributor

@ChaiWithJai ChaiWithJai commented Dec 28, 2021

My prettier and linter have been fighting and blocking my PRs recently. After taking a few minutes, I realized that we haven't been keeping our linting and prettier up-to-date with Ember (prettier was added to Ember in 3.24). I reviewed the Ember standard for linting and prettier in ember-new-output.

This PR sets up Nomad to follow Ember's standard for linting and prettier through the ember-new-output through the latest LTS 3.28.

@github-actions
Copy link

github-actions bot commented Dec 28, 2021

Ember Asset Size action

As of a6b3836

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +645 B +80 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Dec 28, 2021

Ember Test Audit comparison

main a6b3836 change
passes 1259 1258 -1
failures 0 0 0
flaky 0 1 +1
duration 11m 20s 046ms 9m 12s 117ms -2m 07s 929ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

Ember Test Audit detected these flaky tests on 05017e7:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | job-page/parts/placement-failures: when the job has placement failures, they are called out
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

We still use classic classes because this is a mixed
codebase between Octane and Classic.
We have ~60 uses of computed properties across routes (for watcher system), components,
and models.
This is a mixed codebase and still uses classic components
Classic components use lifecycle hooks.
Classic components still use tagName decorator
Async tests should use  in integrations tests.
Acceptance tests are using Mirage and can't use
since we can't know the number of assertions.
@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: facet Status | the Status facet filters the allocations list by Status

Ember Test Audit detected these flaky tests on cae4bec:

  • Integration | Component | job-page/parts/placement-failures: when the job has placement failures, they are called out

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on a6b3836:

  • Acceptance | task group detail: facet Status | the Status facet filters the allocations list by Status

Copy link
Contributor

@LevelbossMike LevelbossMike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if we want to change the looks of the code again we will just create one more big commit after updating the prettier rules.

@ChaiWithJai ChaiWithJai merged commit 81f7d7d into main Jan 24, 2022
@ChaiWithJai ChaiWithJai deleted the b-ui/fix-linter branch January 24, 2022 14:08
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants