-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix linter and prettier #11754
ui: fix linter and prettier #11754
Conversation
Ember Asset Size actionAs of a6b3836 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
Ember Test Audit detected these flaky tests on 05017e7:
|
We still use classic classes because this is a mixed codebase between Octane and Classic.
We have ~60 uses of computed properties across routes (for watcher system), components, and models.
This is a mixed codebase and still uses classic components
Classic components use lifecycle hooks.
Classic components still use tagName decorator
Async tests should use in integrations tests. Acceptance tests are using Mirage and can't use since we can't know the number of assertions.
05017e7
to
2032813
Compare
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on main:
Ember Test Audit detected these flaky tests on cae4bec:
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on a6b3836:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - if we want to change the looks of the code again we will just create one more big commit after updating the prettier rules.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
My prettier and linter have been fighting and blocking my PRs recently. After taking a few minutes, I realized that we haven't been keeping our linting and prettier up-to-date with Ember (prettier was added to Ember in
3.24
). I reviewed the Ember standard for linting and prettier inember-new-output
.This PR sets up Nomad to follow Ember's standard for linting and prettier through the
ember-new-output
through the latest LTS3.28
.